Fix TypeError in ResultPager #1093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone take a look at this PR? Is this project abandoned? |
|
Hi @iwiznia, thanks for the PR! I'm not sure if this is the "right" fix as we hide the actual error by returning an empty array. I don't understand why the httpClient call doesn't throw an exception (through our So for me the fix would rather be to check why there is no exception thrown on this error, something that can be catched by the application and a retry can be executed. Instead of an empty array that could just mean there is no data. wdyt @iwiznia? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091
Not sure if this is the best fix, if it is not, would love guidance on a better one.