Skip to content

[impeccable-bd] B + D copy in impeccable design (/bi, /di) for the copy test - #19

Merged
Smetools merged 1 commit into
mainfrom
hassan-impeccable-bd
May 30, 2026
Merged

[impeccable-bd] B + D copy in impeccable design (/bi, /di) for the copy test#19
Smetools merged 1 commit into
mainfrom
hassan-impeccable-bd

Conversation

@Smetools

@Smetools Smetools commented May 29, 2026

Copy link
Copy Markdown
Collaborator

What

Builds Version B and Version D copy in the impeccable brass/midnight design, on preview routes /bi and /di. This is the head-to-head for the copy A/B test (design held constant, copy is the variable).

Structure

  • New shared kit app/components/impeccable/kit.tsx — the impeccable CSS, chrome (header/footer/floating CTA), motion helpers, and the constant body sections both variants share (Process, Results, Security, FAQ, Close).
  • version-bi.tsx/bi, tracks variant b. B's hero ("Your meetings become verified actions. Automatically.") + the 80-second Odoo PR exhibit.
  • version-di.tsx/di, tracks variant d. D's hero ("...Before it ended.") + the L1/L2/L3 escalation on the numbered rail.
  • Design is the constant; only each page's hero + signature section differs. That's the thing the test measures.

Untouched

  • Cream A/B/C/D and the live impeccable /e control are unchanged.
  • Routes are preview-only — the live A/B split is not rewired in this PR (per plan: eyeball first, wire the 2-way /bi vs /di split after approval).

Notes on record

  • Per your call, B's 80-second Odoo demo and D's agent-action copy ship as-is, even though the shipped-matrix marks the Odoo SH PR demo / cross-org agent actions as not-yet-built (target ~2026-07-31). Flagged earlier; proceeding as directed.

Test plan

  1. Open /bi and /di on the preview — both render the impeccable design with their distinct hero + signature section.
  2. The shared body (Process/Results/Security/FAQ/Close) is identical between them.
  3. /, /b, /c, /d, /e all unchanged.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added two new landing page variants with distinct designs and layouts
    • Introduced custom typography with three Google Fonts for improved visual hierarchy
    • Added interactive sections including process workflow, results showcase, security information, and FAQ
    • Implemented floating call-to-action that appears automatically after 5 seconds
    • Integrated scroll-aware header that responds to page navigation

Review Change Stack

Two preview routes for the copy A/B test: Version B's copy (outcome-first +
80-second Odoo demo) and Version D's copy (show-the-magic + L1/L2/L3
escalation), both rendered in the impeccable brass/midnight design system.

- New shared kit (components/impeccable/kit.tsx): CSS, chrome (header/footer/
  floating CTA), motion helpers, and the constant body sections (Process,
  Results, Security, FAQ, Close) both variants share. Design is the constant;
  only each page's hero + signature section varies.
- version-bi.tsx (/bi, tracks variant 'b'): B hero + Odoo-80s exhibit.
- version-di.tsx (/di, tracks variant 'd'): D hero + 3-level escalation on the
  numbered rail.
- Cream A/B/C/D and the live /e control are untouched. Routes are preview-only;
  the live split is not rewired yet.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 29, 2026 8:05pm

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Adds two new landing page variants (B-impeccable and D-impeccable) sharing a unified design kit. The kit exports CSS, motion utilities, SVG glyphs, and modular section components (header, footer, process, results, security, FAQ, CTA). Variant B emphasizes inbox verification and Odoo workflow; Variant D introduces an escalation rail. Both routes load Google Fonts and compose shared sections into full page layouts.

Changes

Impeccable Landing Page Variants

Layer / File(s) Summary
Shared impeccable design kit: CSS, primitives, motion, and chrome components
app/components/impeccable/kit.tsx
Foundational shared module exporting scoped CSS (IMPECCABLE_CSS), SVG glyphs (Tick, Arrow), motion utilities (useReveal, SectionReveal) respecting reduced-motion, header/footer/floating-CTA chrome components, reusable landing sections (ProcessSection, ResultsSection, SecuritySection, FAQSection, CloseSection), and content arrays (STEPS, RESULTS, PILLARS, FAQS).
Version B-impeccable page: hero and demo sections with route
app/components/version-bi.tsx, app/app/bi/page.tsx
Variant B landing page with Hero section (value proposition, CTA buttons, inbox exhibit) and OdooDemo section (80-second workflow narrative). Page wrapper injects shared CSS, renders all kit sections, wires ABTracker variant tracking, and customizes CloseSection. Route loads three Google Fonts and passes combined fontVars to component.
Version D-impeccable page: escalation section with route
app/components/version-di.tsx, app/app/di/page.tsx
Variant D landing page with LEVELS data defining three escalation tiers (L1/L2/L3 agent actions), animated Hero section with CTAs and inbox screenshot, and Escalation section mapping levels into repeated step blocks with descriptions. Page wrapper composes shared kit sections, injects CSS, wires variant "d" tracking, customizes CloseSection, and passes fontVars. Route loads fonts and renders component.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Two impeccable variants bloom—
B brings the demo magic, D scales the zoom.
A shared kit unites them, neat and so fine,
With swapped fonts and animations that shine. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 23.81% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding B and D copy variants within the impeccable design at routes /bi and /di for a copy test.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hassan-impeccable-bd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/components/impeccable/kit.tsx`:
- Line 343: The Image component usage in app/components/impeccable/kit.tsx
(<Image src="/logos/logo.jpg" ... />) points to a missing asset; either add the
file public/logos/logo.jpg (ensure correct dimensions/format) or update the src
to point to an existing logo (e.g., /logos/logo.png or /images/brand-logo.svg)
and adjust the <Image ... /> props accordingly so the header logo renders
without errors.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fe45a990-44aa-496c-8232-bf95df9abfd0

📥 Commits

Reviewing files that changed from the base of the PR and between 5bd834e and 2ed9ae2.

📒 Files selected for processing (5)
  • app/app/bi/page.tsx
  • app/app/di/page.tsx
  • app/components/impeccable/kit.tsx
  • app/components/version-bi.tsx
  • app/components/version-di.tsx

<header className="ve-header" data-scrolled={scrolled}>
<div className="ve-wrap ve-nav">
<Link href="/" className="ve-brand">
<Image src="/logos/logo.jpg" alt="" width={28} height={28} priority />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if the referenced logo file exists

if [ -f "public/logos/logo.jpg" ]; then
  echo "✓ Logo file exists at public/logos/logo.jpg"
  ls -lh public/logos/logo.jpg
else
  echo "✗ Logo file NOT found at public/logos/logo.jpg"
  echo "Searching for similar files..."
  fd -t f 'logo' public/ 2>/dev/null || find public/ -name '*logo*' -type f 2>/dev/null
fi

Repository: Knowcap-V2/knowcap-landing

Length of output: 148


Fix missing header logo asset (/logos/logo.jpg)

app/components/impeccable/kit.tsx references <Image src="/logos/logo.jpg" ... />, but public/logos/logo.jpg is not present, which will break logo rendering. Add the asset at that path (or update the src to an existing logo file).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/components/impeccable/kit.tsx` at line 343, The Image component usage in
app/components/impeccable/kit.tsx (<Image src="/logos/logo.jpg" ... />) points
to a missing asset; either add the file public/logos/logo.jpg (ensure correct
dimensions/format) or update the src to point to an existing logo (e.g.,
/logos/logo.png or /images/brand-logo.svg) and adjust the <Image ... /> props
accordingly so the header logo renders without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant