Skip to content

[impeccable-polish] WCAG AA + reduced-motion polish on shared A-D system - #15

Merged
Smetools merged 2 commits into
mainfrom
hassan-impeccable-polish
May 29, 2026
Merged

[impeccable-polish] WCAG AA + reduced-motion polish on shared A-D system#15
Smetools merged 2 commits into
mainfrom
hassan-impeccable-polish

Conversation

@Smetools

@Smetools Smetools commented May 29, 2026

Copy link
Copy Markdown
Collaborator

What

Impeccable polish pass on the SHARED design system behind landing versions A/B/C/D. No redesign — same cream / Space Grotesk system, sharper execution. Version E (the brass/dossier variant) is intentionally separate and untouched. DESIGN.md palette + fonts respected.

Changes

Accessibility (the real finding): muted body/meta text failed WCAG AA contrast on every light theme. Bumped the per-theme mutedColor token so subtext, section eyebrows, testimonial titles, and step numbers clear the 4.5:1 body-text bar:

Theme Before After
baseline #8A8F99 (3.11:1 ❌) #6E737D (5.01:1 ✓)
operator-light #999999 (2.41:1 ❌) #6E6E73 (~5:1 ✓)
library #9A8A78 (2.74:1 ❌) #7E6E59 (4.59:1 ✓)
operator-dark #484F58 (fail) #767E8A (~4.6:1 ✓)

Single-token change per theme — the 4-theme switcher is unaffected and still works across all themes.

Reduced motion: added the prefers-reduced-motion: reduce path that was entirely missing. Sections use framer-motion / mount-reveal animations plus a global * transition; reduced-motion users now get instant rendering instead of forced animation.

Typography: text-wrap: balance on h1–h3 and text-wrap: pretty on paragraphs — even heading line-breaks, fewer prose orphans.

Scope notes

  • Only app/components/theme-switcher.tsx (4 token values) and app/app/globals.css (static CSS append) changed. No logic, no layout, no copy changes — zero build risk.
  • The biggest remaining AI-slop tell (a tiny uppercase eyebrow above nearly every section) was left in place deliberately — removing it is a design change, not polish. Flagging it for a separate decision.

Test plan

  1. Open the preview, cycle all 4 themes via the navbar dots — confirm muted text is more legible and nothing else shifts.
  2. Toggle OS "reduce motion" — confirm the page renders without the reveal animations.
  3. Check / /b /c /d still look unified; /e unchanged.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Adjusted muted color palette values across multiple application themes to enhance visual consistency throughout the interface, improve overall color harmony and balance, and refine aesthetic details to deliver a more polished and cohesive user experience across all supported theme options.

Review Change Stack

…-motion

Impeccable polish pass on the shared cream/Space-Grotesk system used by
versions A/B/C/D (version E is separate and untouched). No redesign — same
system, sharper execution. DESIGN.md palette/fonts respected.

- a11y (P1): muted body/meta text failed WCAG AA contrast on every light
  theme. Bumped the `mutedColor` token per theme so small subtext, eyebrows,
  testimonial titles, and step numbers clear 4.5:1:
    baseline       #8A8F99 (3.11:1) -> #6E737D (5.01:1)
    operator-light #999999 (2.41:1) -> #6E6E73 (~5:1)
    library        #9A8A78 (2.74:1) -> #7E6E59 (4.59:1)
    operator-dark  #484F58 (fail)   -> #767E8A (~4.6:1)
  Single-token change per theme; the 4-theme switcher is unaffected.
- a11y: added a global `prefers-reduced-motion: reduce` path. The sections use
  framer-motion / mount-triggered reveals and there's a global `*` transition;
  reduced motion now collapses all of it to instant (was entirely missing).
- typography: `text-wrap: balance` on h1-h3 and `text-wrap: pretty` on
  paragraphs for even heading line-breaks and fewer prose orphans.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment May 29, 2026 4:47pm

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Smetools, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d4f14096-e256-4947-8c28-e7070966ddba

📥 Commits

Reviewing files that changed from the base of the PR and between 339bd53 and 24c74cb.

📒 Files selected for processing (1)
  • app/app/globals.css
📝 Walkthrough

Walkthrough

Theme color definitions in THEME_MAP updated with adjusted mutedColor hex values across four themes: baseline, operator-dark, operator-light, and library. No component logic, hooks, or public APIs were modified.

Changes

Theme color adjustments

Layer / File(s) Summary
Muted color value updates across themes
app/components/theme-switcher.tsx
Four theme definitions in THEME_MAP (baseline, operator-dark, operator-light, library) updated with new mutedColor hex values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🎨 Four palettes painted fresh and bright,
Muted tones adjusted just right,
Baseline, operators, library too—
Colors dancing, a subtle hue,
Small tweaks that make the theme feel new! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions WCAG AA and reduced-motion polish, but the raw summary shows only mutedColor token updates in theme-switcher.tsx (4/-4 lines), with no mention of CSS changes or the reduced-motion/typography work described in objectives. Align the title with the actual changeset. The raw summary indicates only theme token modifications were made, not the full scope claimed in objectives. Either update the title to reflect actual changes or clarify if the summary is incomplete.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hassan-impeccable-polish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The prior commit only landed the theme-switcher contrast fix; this adds the
globals.css half of the polish pass (reduced-motion media query + text-wrap).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Smetools
Smetools force-pushed the hassan-impeccable-polish branch from adfb0f6 to 24c74cb Compare May 29, 2026 16:43
@Smetools
Smetools merged commit 5bd834e into main May 29, 2026
3 checks passed
@Smetools
Smetools deleted the hassan-impeccable-polish branch May 29, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant