Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple panics (and a torture-tool) #47

Closed
abrander opened this issue Feb 23, 2017 · 3 comments
Closed

Multiple panics (and a torture-tool) #47

abrander opened this issue Feb 23, 2017 · 3 comments
Assignees

Comments

@abrander
Copy link
Contributor

First of all; thanks for govaluate. It's awesome! :)

I have written a small torture test for hunting panics:
https://gist.github.com/abrander/fa05ae9b181b48ffe7afb12c961b6e90

The tool does 100,000,000 evaluations in about 10 minutes on my workstation.

I'm not familiar enough with govaluate to fix these panics myself, but maybe someone else could have a look?

#46 fixes many cases.

@Knetic Knetic self-assigned this Feb 23, 2017
@Knetic
Copy link
Owner

Knetic commented Feb 23, 2017

Thanks! And thanks for taking the time to write the tool! I'd looked into fuzzers for testing a while back, but never actually put anything meaningful together - but this is fantastic. Even just running for a couple minutes it's found tens of thousands of panic cases.

I'll probably integrate this into the automated tests at some point after seeing how many of these panics I can get rid of.

@Knetic
Copy link
Owner

Knetic commented Feb 24, 2017

That torture tool is really fantastic. I put it into the test suite (but defaults to skipped, so that only Travisci does it) and fixed the three bugs which seemed to lead to panics. Everything passes now. I'm aiming to do more followup work later, but for now at least all the known cases work.

Thanks again! Closing this since I couldn't find any more panics with the tool.

@Knetic Knetic closed this as completed Feb 24, 2017
@abrander
Copy link
Contributor Author

Wow man, you're fast! Thanks for fixing.

I'm glad you find the tool useful, but I'm not sure how happy Travis is if you're hammering for minutes ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants