-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing slash should be removed from allocator.test_dir
in Knapsack::Runners::SpinachRunner
#57
Comments
I will check that. Did you notice this after update of spinach gem? For now you can manually set test_dir with |
Thanks! ❤️
No, we're on Spinach 0.8.10 since more than 1.5 years! :)
Yep, I figured this out, thanks! |
Maybe a better fix would be |
allocator.test_dir
in Knapsack::Runners::SpinachRunner
allocator.test_dir
in Knapsack::Runners::SpinachRunner
I've released knapsack 1.13.3. Thanks for help! BTW maybe you will find useful Queue Mode in knapsack_pro for auto-balancing CI nodes. |
Thanks @ArturT! |
We, at GitLab, have an issue where the
--features_path
option passed to Spinach is set tofeatures/
: https://github.com/ArturT/knapsack/blob/e2e71d3974653bd3333fbf707fa20a8f0d95e209/lib/knapsack/runners/spinach_runner.rb#L15The problem is that Spinach is not expecting a trailing slash for this option: https://github.com/codegram/spinach/blob/f561ec621dc309c87a60dd2c6ccca48a818ab298/lib/spinach/config.rb#L88
This ends in Spinach failing to require
features/support/env.rb
first: https://github.com/codegram/spinach/blob/f561ec621dc309c87a60dd2c6ccca48a818ab298/lib/spinach/runner.rb#L136-L139I believe we should just call
.chomp('/')
onallocator.test_dir
inKnapsack::Runners::SpinachRunner
and move on with it. :)For more detail about the issue we had, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10395#note_26752554.
The text was updated successfully, but these errors were encountered: