Removed faulty native signed integer implementation

Author: KizzyCode

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "asn1_der"
-version = "0.7.0"
+version = "0.7.1"
 edition = "2018"
 authors = ["KizzyCode Software Labs./Keziah Biermann <[email protected]>"]
 keywords = ["asn1", "asn1-der", "serialize", "deserialize", "no_panic"]

src/typed/integer.rs

@@ -124,30 +124,6 @@ impl<'a> DerEncodable for Integer<'a> {
 
 /// Implements `DerCodable`
 macro_rules! impl_dercodable {
-	(signed: $num:ty) => {
-		impl<'a> DerDecodable<'a> for $num {
-			#[cfg_attr(feature = "no_panic", no_panic::no_panic)]
-			fn load(object: DerObject<'a>) -> Result<Self, Asn1DerError> {
-				// Load integer
-				let integer = Integer::load(object).propagate(e!("Failed to load integer"))?;
-				let buf = integer.copy_numbytes([0; mem::size_of::<Self>()])
-					.propagate(e!("The numeric value is too large"))?;
-				
-				// Validate the integer
-				match Self::from_be_bytes(buf) {
-					num if num.is_negative() && !integer.is_negative() =>
-						Err(eunsupported!("The numeric value is too large")),
-					num => Ok(num)
-				}
-			}
-		}
-		impl DerEncodable for $num {
-			#[cfg_attr(feature = "no_panic", no_panic::no_panic)]
-			fn encode<S: Sink>(&self, sink: &mut S) -> Result<(), Asn1DerError> {
-				Integer::write(&self.to_be_bytes(), self.is_negative(), sink)
-			}
-		}
-	};
 	(unsigned: $num:ty) => {
 		impl<'a> DerDecodable<'a> for $num {
 			#[cfg_attr(feature = "no_panic", no_panic::no_panic)]
@@ -172,8 +148,6 @@ macro_rules! impl_dercodable {
 			}
 		}
 	};
-	(signed: $($num:ty),+) => ($( impl_dercodable!(signed: $num); )+);
 	(unsigned: $($num:ty),+) => ($( impl_dercodable!(unsigned: $num); )+);
 }
-impl_dercodable!(unsigned: u8, u16, u32, u64, u128, usize);
-impl_dercodable!(signed: i8, i16, i32, i64, i128, isize);
+impl_dercodable!(unsigned: u8, u16, u32, u64, u128, usize);

tests/ok.json

@@ -250,14 +250,6 @@
         "tag": 2,
         "value": [0,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255],
         "uint": 340282366920938463463374607431768211455
-      },
-
-      {
-        "name": "Integer (-169099404967786586218975441646099483807)",
-        "bytes": [2,16,128,200,163,165,50,73,204,242,115,179,233,77,225,182,51,97],
-        "tag": 2,
-        "value": [128,200,163,165,50,73,204,242,115,179,233,77,225,182,51,97],
-        "int": -169099404967786586218975441646099483807
       }
     ],
     "null": [

tests/ok_typed.rs

@@ -74,10 +74,8 @@ fn integer() {
 				}
 			};
 			(unsigned: $( $num:ty ),+) => ($( native!($num, uint, |_| false); )+);
-			(signed: $( $num:ty ),+) => ($( native!($num, int, |n: $num| n.is_negative()); )+);
 		}
 		native!(unsigned: u8, u16, u32, u64, u128, usize);
-		native!(signed: i8, i16, i32, i64, i128, isize);
 	}
 }