Show proc time on queryTests.php #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zackgalbreath
commented
Jan 12, 2018
zackgalbreath
commented
- Clean up the queryTests.php API endpoint
- Show Processors & Proc Time on this page when appropriate
- Better display of test timing on this page
Remove unused $required parameter from get_project_from_request(). Assume that a project is required.
get_project_from_request() now calls can_access_project(). The caller is no longer expected to call both functions in sequence.
zackgalbreath
force-pushed
the
proc_time_on_queryTests
branch
from
ad4ddc3 to
0b17163
Compare
We get this for free now by including pdo.php
Previously, queryTests.php showed test timing as a float with no units (ie 0.05). Instead we now show nicely formatted time values, like on viewTest.php (50ms).
bryonbean
approved these changes
Jan 15, 2018
|
Thanks for the review!
All this "proc time" stuff gets tested with manageMeasurements.php because this test creates (and deletes) the "Processors" test measurement, which turns on the proc time feature. I agree that it would probably be cleaner to split these up a bit. Perhaps this is something to keep in mind if/when we start using CTest test fixtures to manage test state dependencies better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.