Update Build model to use PDO #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackgalbreath
force-pushed
the
build_model
branch
from
e009c46 to
d802f13
Compare
added 29 commits
November 1, 2017 11:45
zackgalbreath
commented
Nov 9, 2017
models/build.php
Outdated
| if (pdo_num_rows($result) > 0) { | ||
| $stmt = $this->PDO->prepare( | ||
| 'SELECT id FROM build | ||
| WHERE parentid = 0 AND name = ? AND siteid = ? AND stamp = ? AND |
There was a problem hiding this comment.
Use ParentId const instead of 0 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.