Add support for authenticated submissions #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows logged in users to generate or revoke their tokens.
New UI element allows project admins to restrict submissions to sites bearing a valid authentication token.
Allow users to generate and revoke authentication tokens if they belong to a project that restricts submissions. This change introduces a dependency on ngclipboard. This module is used to allow the user to copy the new authentication token to their clipboard by clicking a button.
This new configuration setting allows CDash admins to dictate whether or not newly created projects should require authentication upon submission by default.
zackgalbreath
commented
May 12, 2017
public/js/controllers/user.js
Outdated
| @@ -13,16 +13,55 @@ CDash.controller('UserController', function UserController($scope, apiLoader) { | |||
| var index = -1; | |||
| for(var i = 0, len = $scope.cdash.jobschedule.length; i < len; i++) { | |||
| if ($scope.cdash.jobschedule[i].id === job.id) { | |||
| index = i; | |||
| break; | |||
| $scope.cdash.jobschedule.splice(index, 1); | |||
There was a problem hiding this comment.
Take a closer look at this change
zackgalbreath
commented
May 12, 2017
public/views/user.html
Outdated
| ng-if="cdash.authtokens.length > 0"> | ||
| <tbody> | ||
| </tbody> | ||
| </table> |
There was a problem hiding this comment.
This table doesn't do anything?
zackgalbreath
force-pushed
the
authenticated_submissions
branch
from
ec1ab76 to
dfa7b2f
Compare
|
Reviewed f2f with @bryonbean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow admins to require authentication tokens for submissions to their project.