Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused http-factory-guzzle dependency #2718

Merged

Conversation

williamjallen
Copy link
Collaborator

http-interop/http-factory-guzzle appears to be unused. This PR removes it from our requirements list.

@williamjallen
Copy link
Collaborator Author

It looks like there are a few usages in the legacy tests.

@williamjallen williamjallen deleted the remove-http-factory-guzzle branch February 21, 2025 15:24
@williamjallen williamjallen restored the remove-http-factory-guzzle branch February 21, 2025 18:43
@williamjallen williamjallen reopened this Feb 21, 2025
@williamjallen
Copy link
Collaborator Author

I experienced failures locally which I misattributed to this change. This dependency shouldn't have an effect on the tests.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Feb 26, 2025
Merged via the queue into Kitware:master with commit ad9fecb Feb 26, 2025
14 checks passed
@williamjallen williamjallen deleted the remove-http-factory-guzzle branch February 26, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants