Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy site information deduplication behavior #2711

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

williamjallen
Copy link
Collaborator

Site information is currently mistakenly saved on every submission, regardless of whether any information actually changed. This PR fixes the issue and adds tests to prevent it from occurring again.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@josephsnyder josephsnyder added this pull request to the merge queue Feb 14, 2025
Merged via the queue into Kitware:master with commit 5f0a637 Feb 14, 2025
7 checks passed
@williamjallen williamjallen deleted the site-information-bugfix branch February 14, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants