Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul site information page #2661

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

williamjallen
Copy link
Collaborator

@williamjallen williamjallen commented Jan 13, 2025

The site information page /sites/<id> is currently somewhat broken, and does not present much useful information. This PR is the first of several planned as part of a revitalization of the CDash site feature. The entire UI was rebuilt with DaisyUI based on information provided via the GraphQL API. Further improvements remain to be made, including:

  • The "claim site" feature should be moved to this page
  • Site information should be editable directly from this page
  • Aggregate time per project, current site location, and build status information should be added

Closes #1126

Related to #1984

New UI:
image

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the page update but I have one nit to pick. A single submission from a new site created four History system updates all with identical information at the same time (down to the second). Is there a way to group them by time of submission or something else?

image

@williamjallen
Copy link
Collaborator Author

@josephsnyder Do you see four results in the database? You can run select * from siteinformation where siteid = ?; to check.

I think the page should display whatever the server sends back, even if that means that duplicate information is displayed. Instead, I think we should fix the root of the problem, which is the bad deduplication. I noticed some odd preexisting behavior related to site information deduplication that I plan to work on in a separate PR. Thoughts?

@josephsnyder
Copy link
Member

@williamjallen,

@josephsnyder Do you see four results in the database? You can run select * from siteinformation where siteid = ?; to check.

Correct. There are 4 entries for this particular siteid so it looks like a deduplication problem.

@williamjallen
Copy link
Collaborator Author

@josephsnyder I'll add some logic to ignore duplicates for the moment, until I can resolve the deduplication issue.

@josephsnyder
Copy link
Member

Also, @williamjallen, I just found that one of the test sites returns mostRecentInformation: null and the loading spiral isn't going away. I'm not sure how often we'll get a null case but it might be worth accounting for:

image

@williamjallen
Copy link
Collaborator Author

@josephsnyder Good idea. It should theoretically be impossible to have a site without information in a production system, but it certainly can't hurt to handle the case if it does happen for whatever reason.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and all my comments were addressed!

@josephsnyder josephsnyder added this pull request to the merge queue Jan 14, 2025
Merged via the queue into Kitware:master with commit 9fd9dcc Jan 14, 2025
6 checks passed
@williamjallen williamjallen deleted the site-page-overhaul branch January 14, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewSite.php shows "No system information available at this time" for many sites
2 participants