-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul site information page #2661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josephsnyder Do you see four results in the database? You can run I think the page should display whatever the server sends back, even if that means that duplicate information is displayed. Instead, I think we should fix the root of the problem, which is the bad deduplication. I noticed some odd preexisting behavior related to site information deduplication that I plan to work on in a separate PR. Thoughts? |
Correct. There are 4 entries for this particular siteid so it looks like a deduplication problem. |
@josephsnyder I'll add some logic to ignore duplicates for the moment, until I can resolve the deduplication issue. |
Also, @williamjallen, I just found that one of the test sites returns |
@josephsnyder Good idea. It should theoretically be impossible to have a site without information in a production system, but it certainly can't hurt to handle the case if it does happen for whatever reason. |
ced6e3d
to
72be3a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and all my comments were addressed!
The site information page
/sites/<id>
is currently somewhat broken, and does not present much useful information. This PR is the first of several planned as part of a revitalization of the CDash site feature. The entire UI was rebuilt with DaisyUI based on information provided via the GraphQL API. Further improvements remain to be made, including:Closes #1126
Related to #1984
New UI:
