Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AuthTokenUtil SQL query #2656

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix AuthTokenUtil SQL query #2656

merged 1 commit into from
Jan 8, 2025

Conversation

josephsnyder
Copy link
Member

@josephsnyder josephsnyder commented Jan 8, 2025 •
edited by williamjallen
Loading

In #2614, the user table was renamed to users. Update the SQL query used in the AuthTokenUtil to use the new table instead of the old name.

Fixes: #2655

@josephsnyder josephsnyder self-assigned this Jan 8, 2025
@williamjallen
Copy link
Collaborator

Given that this is a new issue with at least moderate impact upon many users' workflows, I think we should target the 3.7 branch instead of master.

@williamjallen williamjallen added this to the v3.7 milestone Jan 8, 2025
@josephsnyder josephsnyder changed the base branch from master to releases/3.7 January 8, 2025 14:48
@josephsnyder
Fix AuthTokenUtil SQL query
6b96c50 
In #2641, the `user` table was renamed to `users`.  Update the SQL
query used in the AuthTokenUtil to use the new table instead of the
old name.

Fixes: #2655
@josephsnyder josephsnyder force-pushed the fix_auth_token_util_sql branch from 5e0039b to 6b96c50 Compare January 8, 2025 14:49
williamjallen
williamjallen approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! It looks like I originally wrote this before I fully understood how Laravel relationships are supposed to work. I'll refactor this in another PR to avoid this kind of issue in the future by offloading these joins to Eloquent.

@williamjallen williamjallen added this pull request to the merge queue Jan 8, 2025
Merged via the queue into releases/3.7 with commit 8a2c320 Jan 8, 2025
6 checks passed
@williamjallen williamjallen deleted the fix_auth_token_util_sql branch January 8, 2025 15:33
@williamjallen williamjallen mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamjallen williamjallen williamjallen approved these changes

Assignees

@josephsnyder josephsnyder

Labels
release notes: fixes
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.

500 error on load of Manage Authentication Tokens
2 participants
@josephsnyder @williamjallen