Replace cdashmail() email logging with Laravel event listener #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferred way to handle email notifications in Laravel is to use Mailables. Any emails sent outside the legacy
cdashmail()function, including Mailables, cannot take advantage of the email logging functionalitycdashmail()provides.This PR moves that logging functionality to an "Event Listener"--Laravel's preferred way to respond to events such as emails being sent.
cdashmail()was also removed since the logging changes rendered it obsolete.I plan to make a series of PRs to convert each of our raw text emails to Mailables in the future.