Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor notification/email inheritance structure #2620

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

williamjallen
Copy link
Collaborator

While initially developed with good intentions, the email notification system has become a major pain point for developers due to the convoluted hierarchy of classes and interfaces. A better solution for handling notifications is Laravel's built-in notification system. This PR deletes many unnecessary interfaces, adds type annotations to notification code where possible, and otherwise cuts down on unnecessary technical debt.

@fspindle
Copy link

To be able to use smtp I had to modify config/mail.php setting verify_peer to false.

        'smtp' => [
            'transport' => 'smtp',
            'host' => env('MAIL_HOST', 'smtp.mailgun.org'),
            'port' => env('MAIL_PORT', 587),
            'encryption' => env('MAIL_ENCRYPTION', 'tls'),
            'username' => env('MAIL_USERNAME'),
            'password' => env('MAIL_PASSWORD'),
            'timeout' => null,
            'local_domain' => env('MAIL_EHLO_DOMAIN'),
	    'verify_peer' => false,
	],

@williamjallen
Copy link
Collaborator Author

@fspindle Just to clarify, that behavior is not different between my branch and master, correct? This is a maintenance PR which should not have any effect on the current behavior.

@fspindle
Copy link

Yes, you are right. The behavior is the same as in the master branch. I just wanted to share that adding 'verify_peer' => false makes email notification working like adding the same line to the master branch (See #2618)

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't send any emails from my test installation but the tests pass and the code seems in good shape. LGTM

@josephsnyder josephsnyder added this pull request to the merge queue Dec 17, 2024
Merged via the queue into Kitware:master with commit 1f88099 Dec 17, 2024
6 checks passed
@williamjallen williamjallen deleted the mail-cleanup branch December 17, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants