-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor notification/email inheritance structure #2620
Conversation
To be able to use
|
@fspindle Just to clarify, that behavior is not different between my branch and master, correct? This is a maintenance PR which should not have any effect on the current behavior. |
Yes, you are right. The behavior is the same as in the master branch. I just wanted to share that adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't send any emails from my test installation but the tests pass and the code seems in good shape. LGTM
While initially developed with good intentions, the email notification system has become a major pain point for developers due to the convoluted hierarchy of classes and interfaces. A better solution for handling notifications is Laravel's built-in notification system. This PR deletes many unnecessary interfaces, adds type annotations to notification code where possible, and otherwise cuts down on unnecessary technical debt.