Rename user table to users
#2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Dec 10, 2024
|
@williamjallen, after a rebase this should be good to go! Unless you want Zack to look at it too. |
williamjallen
force-pushed
the
rename-user-to-users
branch
from
5a1a4c8 to
5f28220
Compare
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDash currently stores user information in the
usertable. Unfortunately, this name conflicts with the default Postgresusertable, leading to confusion and extra logic to quote theusername whenever it is used. As discussed in #2589 (comment), Laravel's DatabaseTruncation trait contains a bug where the table name is not quoted properly. That provided the motivation necessary to change the table name in CDash so we don't run into this issue in the future.