Add Laravel Dusk for e2e browser testing #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failure appears to be caused by a Laravel bug in the |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
CDash currently stores user information in the `user` table. Unfortunately, this name conflicts with the default Postgres `user` table, leading to confusion and extra logic to quote the `user` name whenever it is used. As discussed in #2589 (comment), Laravel's DatabaseTruncation trait contains a bug where the table name is not quoted properly. That provided the motivation necessary to change the table name in CDash so we don't run into this issue in the future.
williamjallen
force-pushed
the
laravel-dusk
branch
from
8b425bc to
fe246c9
Compare
josephsnyder
approved these changes
Dec 17, 2024
josephsnyder
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress works very well and is easy to use, but the inability to interact with the database while testing makes it difficult to write thorough tests. This PR adds support for Laravel Dusk, Laravel's Selenium wrapper, which allows us to interact with the database and make submissions between test cases. It also truncates the database tables after every test case. Even though it isn't as easy to use, it will allow us to write better test cases and eliminate the need to mock the GraphQL API.