Overhaul project sites page #2583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackgalbreath
approved these changes
Nov 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
This PR fixes an issue introduced in #2583 where sites without any attached site information prevent the entire page from rendering properly. I plan to add thorough e2e tests for this page once I finish getting Laravel Dusk set up.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
While writing end-to-end tests for the project sites page overhauled in #2583 as a proof-of-concept for the upcoming addition of Laravel Dusk, I discovered that the project sites page does not paginate correctly. This PR fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "site map" page is currently very slow on large production instances, and is also partially broken. This PR completely overhauls the page, using Vue and GraphQL behind the scenes to render content faster. I plan to make a series of UI improvements to this page in the near future via separate PRs.