Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure configureerror FK types match #2582

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

zackgalbreath
Copy link
Contributor

CDash databases that were initialized in v2.5 or older have a type mismatch between configure.id (int) and configureerror.configureid (bigint). See #506 for more context about where this mismatch occurred.

Update the recent migration so that these types match and we can apply the foreign key successfully.

CDash databases that were initialized in v2.5 or older
have a type mismatch between configure.id (int) and
configureerror.configureid (bigint). See #506 for more context about where
this mismatch occurred.

Update the recent migration so that these types match and we can
apply the foreign key successfully.
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about changing the type for the ID column to an unsigned bigint "ID" type? (use the ->id() and ->foreignId() to automatically create these types) That's the "correct" solution to this problem throughout the codebase, but might be more work than it's worth for this PR if the goal is to fix something which is currently broken on master.

@zackgalbreath
Copy link
Contributor Author

What do you think about changing the type for the ID column to an unsigned bigint "ID" type? (use the ->id() and ->foreignId() to automatically create these types) That's the "correct" solution to this problem throughout the codebase, but might be more work than it's worth for this PR if the goal is to fix something which is currently broken on master.

I considered this, but opted for the minimal fix here. My reasoning was that we're already making a bunch of database schema changes for 3.7 and I don't want this upgrade to be too painful for our users.

I agree that we should use consistently ID types throughout CDash. Perhaps we can revisit this for a future release that contains fewer ALTER TABLE migrations.

@williamjallen williamjallen added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit 74041b5 Nov 22, 2024
6 checks passed
@williamjallen williamjallen deleted the fix_configureerror_fk_migration branch November 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants