Use more foreign keys for cascading deletions #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use foreign keys to automatically delete records from the following tables: * buildfailure2argument * test2image * updatefile
This "TestSchema" migration was introduced in CDash v3.0. We recommend upgrading any remaining CDash 2.x instances to CDash 3.6 (preferably older) before continuing to upgrade to the latest release.
There was a problem hiding this comment.
It's worth noting that I currently have partially completed work locally which will formalize the testing of migrations by running each one forwards->backwards->forwards with nontrivial data in the database. That work will replace any test coverage lost here.
williamjallen
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use foreign keys to automatically delete records from the following tables: