Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve static asset build process and cache headers #2560

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

williamjallen
Copy link
Collaborator

This PR improves the static asset build process by using the Mix build system to copy all static files instead of only those which are compiled or relocated. By making Mix aware of all of the static assets, the mix() helper function can be used to add cache busting extensions to all static asset file paths. This in turn allows an aggressive cache policy to be put in place. Although the caching policy only resulted in a marginal speedup in my local environment, I expect it to have a more significant impact in production environments where assets have to travel a greater distance.

TODO: Remove all inline script tags in a future PR
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache busting looks good for the CSS files that are easily changed and have distinct objects in the "Network" tab of Firefox. No other issues with the usage of CDash in brief manual testing on the testing data.

@josephsnyder josephsnyder added this pull request to the merge queue Nov 15, 2024
Merged via the queue into Kitware:master with commit 236cfd4 Nov 15, 2024
6 checks passed
@williamjallen williamjallen deleted the relocate-public-files branch November 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants