Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Vue build warnings #2548

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

williamjallen
Copy link
Collaborator

Vue currently emits a number of build warnings when run in development mode via npm run dev. This PR addresses those warnings. In the future, it would be useful to integrate a check for these warnings into our CI pipeline somehow.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors disappear nicely! Once the linter errors are fixed, LGTM!

@williamjallen williamjallen added this pull request to the merge queue Nov 6, 2024
Merged via the queue into Kitware:master with commit 22f1c40 Nov 6, 2024
6 checks passed
@williamjallen williamjallen deleted the vue-build-warnings branch November 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants