Overhaul Mix build #2524
Merged
Overhaul Mix build #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williamjallen, how supported is the "hot reloading" in this MR? I'm running into an issue when using it, but don't want to request changes if there are still things coming. |
|
@josephsnyder Hot reloading is still not usable. This PR is pretty much just a refactor of the build process so I can more easily tackle problems like hot reloading in the future. The main improvement in this PR is the improved cache busting behavior. |
josephsnyder
approved these changes
Nov 4, 2024
All files will now be overwritten, so no need to delete the old build files first.
williamjallen
force-pushed
the
mix-build-cleanup
branch
from
a4b3513 to
003a3e4
Compare
zackgalbreath
added a commit
that referenced
this pull request
Nov 13, 2024
After #2524 we started seeing 404 errors when attempting to load 3rdparty.min.js and legacy_1stparty.min.js for Angular and Vue pages. The solution is to meticulously wrap all our calls to mix() in asset().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of several aiming to clean up our frontend website build process and overall asset structure. This PR overhauls the Mix build script, leading to better cache busting behavior for some assets.
Future work includes: