Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emailing multiple site maintainers #2520

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

zackgalbreath
Copy link
Contributor

Prior to this commit, attempting to email multiple site maintainers from the manageProjectRoles.php page would result in the following error:

Email "[email protected], [email protected]" does not comply with addr-spec of RFC 2822.

Fixes #2450
Follow-up to #2505

@zackgalbreath zackgalbreath force-pushed the fix_site_maintainers_email branch from f92d31e to 66f62f9 Compare October 29, 2024 14:40
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Our email/notifications functionality is overdue for a refactor eventually. As part of that, we should definitely improve our email tests.

Do you want to include this in 3.6 or defer to 3.7?

@zackgalbreath
Copy link
Contributor Author

Do you want to include this in 3.6 or defer to 3.7?

Good question. I think it makes sense to include this in 3.6 since it fixes broken functionality.

@zackgalbreath zackgalbreath changed the base branch from master to releases/3.6 October 29, 2024 14:59
Prior to this commit, attempting to email multiple site maintainers from the
manageProjectRoles.php page would result in the following error:

  Email "[email protected], [email protected]" does not comply
  with addr-spec of RFC 2822.

Fixes #2450
Follow-up to #2505
@zackgalbreath zackgalbreath force-pushed the fix_site_maintainers_email branch from 66f62f9 to 333f788 Compare October 29, 2024 15:01
@williamjallen williamjallen added this pull request to the merge queue Oct 29, 2024
Merged via the queue into releases/3.6 with commit 1df0efb Oct 29, 2024
6 checks passed
@williamjallen williamjallen deleted the fix_site_maintainers_email branch October 29, 2024 15:40
@williamjallen williamjallen added this to the v3.6 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email notifications to send via "Send email to all the site maintainers"
2 participants