Change migration batching approach to avoid problematic syntax on MySQL #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
migration-batching-bugfix
branch
from
4a25691 to
6259b99
Compare
database/migrations/2024_08_24_160326_label2test_relationship_refactor.php
Show resolved
Hide resolved
williamjallen
force-pushed
the
migration-batching-bugfix
branch
from
6259b99 to
3a8a9b3
Compare
zackgalbreath
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported compatibility issues with the recent batched update approach used in several migrations, including #2496. MySQL 8.3 does not support LIMIT clauses on multi-table update statements.
This PR changes the batching approach used for the two migrations affected by these issues to avoid the problematic syntax.