Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter names more user friendly #2497

Merged

Conversation

williamjallen
Copy link
Collaborator

The new GraphQL-based filters interface currently shows the raw GraphQL field name as the filter name. This PR improves the UI by rendering the filter names in Title Case.

image

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and is definitely more readable,

One nitpick: Running Time as the filter name, but the column displays just Time. Can we settle on one string for both in the future?

@josephsnyder josephsnyder added this pull request to the merge queue Oct 15, 2024
@williamjallen
Copy link
Collaborator Author

@josephsnyder Good call. I'll open a PR to change the column display name to "Running Time" to prevent confusion.

Merged via the queue into Kitware:master with commit 0cc5fa9 Oct 15, 2024
6 checks passed
@williamjallen williamjallen deleted the human-readable-filter-names branch October 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants