Migrate label2test rows in batches #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zackgalbreath Do you have any concerns about this approach compared to the patch you sent me? |
zackgalbreath
approved these changes
Oct 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…QL (#2506) Users have reported compatibility issues with the recent batched update approach used in several migrations, including #2496. MySQL 8.3 does not support LIMIT clauses on multi-table update statements. This PR changes the batching approach used for the two migrations affected by these issues to avoid the problematic syntax.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
As reported in #2552 (comment), #2496 introduced a divide-by-zero error in the migration `2024_08_24_160326_label2test_relationship_refactor`. This PR fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2390 added a migration which affects every row in the
label2testtable. MySQL is very inefficient at bulk updates, and real-world test have shown that the running time can be reduced by using small batches. This PR updates the migration to use a batching approach for both MySQL and Postgres.