Change build2test id column type to bigint #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
build2test-id-migration
branch
2 times, most recently
from
ef910ec to
201e554
Compare
williamjallen
force-pushed
the
build2test-id-migration
branch
from
201e554 to
bb88f73
Compare
josephsnyder
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported issues migrating to post-3.5 commits on master, such as in #2448, due to an inconsistency between database schemas between CDash 2 and 3. This PR resolves the issue by changing the type of the
build2testidcolumn to an unsigned bigint, in accordance with Laravel tradition. This also avoids potential overflow concerns. I plan to make a series of future PRs to change the rest of the ID columns to unsigned bigints.