Add details and time columns to new tests page #2465
Conversation
williamjallen
force-pushed
the
test-details-and-time
branch
from
c4e7792 to
838826a
Compare
There was a problem hiding this comment.
One issue with the filtering found on builds/##/tests where the runningTime returns an error when attempting to show an element for the value to filter over. The Details being a plain string is also a little strange, Do we know all options for the field like we do for Status?
There was a problem hiding this comment.
Better! The field's value selector is populated now. It's difficult to find an equal to time, as we only get whole numbers in the selector but the values will have decimal places. It would be helpful for things that are whole number like 60 minutes or so.
Greater/Less than work great and will likely be more what people are using the page for.
|
@josephsnyder Good catch! Of my next big priorities is to add new functionality to the filters interface, so I'll add better float support to the list of functionality to add. |
#2439 introduced a new tests page which will eventually supersede
viewTest.php. This PR adds the time and details columns displayed on viewTest.php to the new tests page. As part of this work, test details and running time are now available via the GraphQL API.