Allow session cookies over HTTP if APP_URL starts with http:// #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2458 removed the requirement for production sites to operate over HTTPS, but did not change the configuration option which allows session cookies to be sent over HTTP. This PR changes that option to allow session cookies to work over HTTP. Operating a CDash site over HTTP is insecure and is not recommended for most users.
User sessions don't really make sense for a HTTP site, since sessions cannot be secured. If there is interest and financial support in the future, it may be interesting to investigate simply turning off the ability to log in altogether for HTTP sites.
Closes #2461