Allow production sites to operate over HTTP #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
#2458 removed the requirement for production sites to operate over HTTPS, but did not change the configuration option which allows session cookies to be sent over HTTP. This PR changes that option to allow session cookies to work over HTTP. Operating a CDash site over HTTP is insecure and is not recommended for most users. User sessions don't really make sense for a HTTP site, since sessions cannot be secured. If there is interest and financial support in the future, it may be interesting to investigate simply turning off the ability to log in altogether for HTTP sites. Closes #2461
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
#2458 removed a line which was believed to have no effect. After deploying a recent version of CDash to a production system based on Kubernetes, it was discovered that Laravel automatically changes the protocol to `http://` if the incoming request is a HTTP request, even if the `APP_URL` starts with `https://`. This PR addresses the issue by forcing Laravel to respect the protocol specified by the `APP_URL` environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDash currently requires all production sites to operate over HTTPS, even if the
APP_URLhas a HTTP prefix. There is no technical reason why this requirement is necessary at this point, and some users may desire to forgo setting up certificates for a small internal instance, such as #2457. This PR removes this requirement and fully respects theAPP_URLas configured.