Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /projects load performance #2454

Merged

Conversation

williamjallen
Copy link
Collaborator

/projects currently shows a loading indicator briefly on large production instances with many builds. This PR attempts to address the issue by adding a buildCount field to the Project type in the GraphQL API, which allows filtered count queries to be executed more efficiently. I plan to add similar fields for build errors/warnings, tests, etc in the future.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a small number of projects, the buildCount field appears and is respected by the /projects page. LGTM!

@josephsnyder josephsnyder added this pull request to the merge queue Sep 24, 2024
Merged via the queue into Kitware:master with commit d51fe67 Sep 24, 2024
6 checks passed
@williamjallen williamjallen deleted the build-count-graphql-field branch September 24, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants