Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move angular_view function to AbstractController #2443

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Move angular_view function to AbstractController #2443

merged 1 commit into from
Sep 18, 2024

Conversation

williamjallen
Copy link
Collaborator

The angular_view() method was previously dynamically attached to the response() facade by Laravel. This PR moves it to the AbstractController class. This change has two main benefits:

  1. PHPStan is able to understand the method better
  2. Any project or build information is now passed into the view automatically by building off of the existing view() method.

@williamjallen williamjallen added this to the v3.6 milestone Sep 17, 2024
josephsnyder
josephsnyder approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on brief manual testing!

@josephsnyder josephsnyder added this pull request to the merge queue Sep 18, 2024
Merged via the queue into Kitware:master with commit b785237 Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: maintenance
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder