Stop assuming "full name" in OAuth #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
requested changes
Sep 9, 2024
josephsnyder
force-pushed
the
stop_full_name_assumption
branch
4 times, most recently
from
6edaf92 to
815ea3a
Compare
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name. Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name. Fixes: Kitware#2435
josephsnyder
force-pushed
the
stop_full_name_assumption
branch
from
815ea3a to
3ba519e
Compare
williamjallen
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a bug report, if an OAuth account name doesn't use a real name, CDash will 500 if a space doesn't exist in the name.
Check for the space before trying to separate into first and last names. If no space, use the whole string as the first name.
Fixes: #2435