Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move contents of ctestparserutils.php to SubmissionUtils #2402

Merged

Conversation

williamjallen
Copy link
Collaborator

This PR continues our ongoing effort to modernize the codebase by moving legacy files to utility classes in the new part of the codebase.

@williamjallen
Copy link
Collaborator Author

@sbelsk feel free to close this if you feel that it conflicts with your work too much. I tried to get this in at a time when not many changes to the file are in flight, but I can reopen this at a future point if it conflicts with your current work.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamjallen williamjallen added this pull request to the merge queue Sep 5, 2024
Merged via the queue into Kitware:master with commit 0e536b2 Sep 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants