Rename BuildNotes to Comments #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDash confusingly has "notes", which are uploaded by CTest and are often used to upload artifacts, and "build notes", which are comments users leave on a given build via the web UI. While both types of notes are poorly named, build notes are by far the easiest to rename, so the decision has been made to rename them to "comments" to better reflect their true purpose. This PR renames build notes to comments across the codebase, while moving to an Eloquent model and generally modernizing the underlying code. I plan to make a follow-up PR to expose these comments via the GraphQL API and convert the UI to use the new API.