Refactor legacy UserProject model #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is only used once, so I just moved it to the controller where it is used.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
The functions used to create projects for much of the test suite currently return legacy project models, even though most tests immediately convert them to Eloquent models. This make the test-writing process extra painful for most tests, and is completely unnecessary. This PR changes the project creation functions to instead return Eloquent projects. This also removes some of the last references to the InitialSetup method in the legacy project model, which paves the way for that method to be completely removed in the follow-up to #2396.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
#2396 inadvertently used the incorrect syntax to access values from a pivot table, which led to users being unable to perform admin actions on AngularJS pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy UserProject model will eventually be superseded by Eloquent relationships between the User and Project models. This PR contains incremental progress towards the goal of getting rid of this legacy model. I expect to finish this refactor in a separate PR once a handful of other changes are complete. For now, most of the "easy" work is done.