Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up basic build group Eloquent relationships #2394

Merged

Conversation

williamjallen
Copy link
Collaborator

This PR is incremental progress towards an entirely Eloquent-based query system, and ultimately an introduction of build groups to the GraphQL API. In addition to setting up Eloquent relationships between build group-related models, this PR also adds additional constraints and indexes for better performance and data integrity.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure to start on MySQL seems legit: a manual run has more info than the CI in the comments

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamjallen williamjallen force-pushed the buildgroup-relationships branch from 67636ac to e66ff1e Compare September 4, 2024 16:31
@williamjallen williamjallen added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@williamjallen williamjallen added this pull request to the merge queue Sep 4, 2024
Merged via the queue into Kitware:master with commit ddf49ce Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants