Display API errors on AngularJS pages #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackgalbreath
force-pushed
the
display_api_errors_for_angular_pages
branch
from
da6ffcd to
2dd4a8f
Compare
williamjallen
requested changes
Aug 7, 2024
app/cdash/include/api_common.php
Outdated
| @@ -63,7 +63,7 @@ function can_access_project($projectid): bool | |||
|
|
|||
| $logged_in = Auth::check(); | |||
| if ($logged_in) { | |||
| abort(403, 'You do not have permission to access this page.'); | |||
| abort(404, 'Project not found.'); | |||
There was a problem hiding this comment.
I believe this entire function could be replaced with the following:
function can_access_project($projectid): bool
{
Gate::authorize('view-project', $project);
return true;
}
Gate::authorize will automatically handle throwing the right type of error (either 401 or 403 depending on login status).
This function is on my shortlist of functions to refactor eventually but doing this would be a decent immediate solution.
There was a problem hiding this comment.
Unconditionally using Gate::authorize got rid of the requirelogin:1 redirect logic we have. But I do like using this function rather than abort() for consistent error messaging.
zackgalbreath
force-pushed
the
display_api_errors_for_angular_pages
branch
from
2dd4a8f to
ba44f3b
Compare
williamjallen
approved these changes
Aug 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.