Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate passwords with Laravel helper #2343

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Generate passwords with Laravel helper #2343

merged 1 commit into from
Jul 22, 2024

Conversation

williamjallen
Copy link
Collaborator

We currently use our own homemade password generation function. This PR removes our homemade password generation function in favor of Laravel's officially supported password generation helper.

@williamjallen williamjallen added this to the v3.6 milestone Jul 16, 2024
josephsnyder
josephsnyder approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token generation and the user registration page looks good. I can't see the email sent by the "Reset Password" page, but I'm feeling confident about it.

@williamjallen williamjallen added this pull request to the merge queue Jul 22, 2024
Merged via the queue into Kitware:master with commit e831686 Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: maintenance
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder