Relate test measurements to tests instead of test outputs #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
testmeasurements-relationships
branch
2 times, most recently
from
df087e4 to
91dcf6a
Compare
williamjallen
force-pushed
the
testmeasurements-relationships
branch
from
91dcf6a to
ee73326
Compare
josephsnyder
approved these changes
Jul 24, 2024
zackgalbreath
approved these changes
Jul 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test measurements are currently related to test outputs under the faulty assumption that the output of a test is directly related to the measurements collected for that test. This means that if the measurements change but the output doesn't, CDash may report incorrect results. This is presumably a very rare edge case which hasn't been identified before. There are also other issues associated with the current form of our test output table, which I plan to fix in upcoming PRs.
This PR changes the relationship of test measurements to instead be related to test results, rather than deduplicated "test outputs".