Improve the submission XML validation script #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
requested changes
Jul 8, 2024
sbelsk
force-pushed
the
refactor-xml-validator
branch
from
c15e713 to
5e47ef8
Compare
williamjallen
approved these changes
Jul 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
This is a follow up to the submission XML schemas along with the validation artisan command (see #2335) that were recently introduced. The changes in this PR add the option to use this validation process on incoming submission files, although this option is disabled by default. A test has been added to verify these changes, and the docs have been updated to reflect the new configuration option. --------- Co-authored-by: Joseph Snyder <[email protected]> Co-authored-by: William Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands on the initial implementation of the submission XML validator introduced in #2277. The validator now supports parsing bigger XML files, can process multiple files per invocation, and provides better error handling. The logic for determining the submission XML file type has been pulled out to be used by both the submission parsers and the XML validation code.
To use the validator from a CDash container, run:
where
<cdash_base>is the path to the application root directory (e.g.,/cdash), and<xml_file>...are one or more file paths to to be validated.