Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema for Configure XML types #2287

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

sbelsk
Copy link
Collaborator

@sbelsk sbelsk commented Jun 28, 2024

This PR follows up on #2277 and introduces an initial schema for "Configure" XML file types accepted by the CDash submission process. The schema has been tested against all configure XML data files in the CDash repo.

The changes also pull out some common element types into a common.xsd file to be reused by the other schema files.

github-merge-queue bot pushed a commit that referenced this pull request Jun 29, 2024
As part of our efforts to improve the CDash submission process, we
working to introduce XML schematics to help with submission validation.
The first of these PRs merged is
#2277. The changes in this PR
refactor some common element types that appear in many of the different
XML types, and pull them out to a common file so they can be reused and
instead of redefined by the other schema files. For an example where
these elements type are used, see
#2287.
@sbelsk sbelsk force-pushed the configure-xml-schema branch from 4219c2c to 2ed9bde Compare June 29, 2024 21:53
@sbelsk sbelsk added this to the v3.5 milestone Jun 29, 2024
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure and types of this schema seem reasonable to me. This successfully passes against all of the configure files I have.

@zackgalbreath zackgalbreath added this pull request to the merge queue Jul 3, 2024
Merged via the queue into Kitware:master with commit 0857b41 Jul 3, 2024
6 checks passed
@sbelsk sbelsk deleted the configure-xml-schema branch July 13, 2024 14:15
@sbelsk sbelsk restored the configure-xml-schema branch July 13, 2024 14:15
@sbelsk sbelsk deleted the configure-xml-schema branch July 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants