Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-architect submission handler inheritance hierarchy #2285

Merged

Conversation

williamjallen
Copy link
Collaborator

Despite being the core of CDash as a product, the submission handlers are currently messy, with lots of duplicated code, subclass-specific logic in superclasses, and convoluted code paths after being hacked on for two decades.

This foundational PR eliminates several interfaces which were previously being treated as abstract classes, with many identical redefinitions of the same methods. All of the raw includes of handlers have also been cleaned up, in support of a fully-autoloaded future. I plan to properly namespace the handlers so they can be autoloaded by the default autoloader instead of our custom autoloader in a future PR. In a separate string of future PRs, I plan to slowly begin the process of pulling out common logic into base classes and moving subclass-specific logic down into those subclasses.

@williamjallen williamjallen added this to the v3.6 milestone Jul 1, 2024
Copy link
Collaborator

@sbelsk sbelsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the tests seem to pass.

@williamjallen williamjallen force-pushed the submission-handler-inheritance branch from d8a1e5b to eb31a24 Compare July 5, 2024 12:58
@williamjallen williamjallen enabled auto-merge July 5, 2024 13:00
@williamjallen williamjallen added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@williamjallen williamjallen added this pull request to the merge queue Jul 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 5, 2024
@williamjallen williamjallen added this pull request to the merge queue Jul 5, 2024
Merged via the queue into Kitware:master with commit 4e27d50 Jul 5, 2024
6 checks passed
@williamjallen williamjallen deleted the submission-handler-inheritance branch July 5, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants