Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require "OK" in simpletest output to pass #2262

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

williamjallen
Copy link
Collaborator

It is currently possible for exceptions to go unnoticed in our simpletest test cases, because the CTest regex is not strict enough. For example, this error has been in our test logs for a very long time: (source)

/cdash/app/cdash/tests/test_lotsofsubprojects.php
All Tests
unlink '/cdash/storage/logs/cdash.log'

In test_lotsofsubprojects.php line 30:
                                                                      
  unlink(LotsOfSubprojects_Configure.xml): No such file or directory

@williamjallen williamjallen added this to the v3.5 milestone Jun 10, 2024
@zackgalbreath zackgalbreath enabled auto-merge June 10, 2024 15:45
@zackgalbreath zackgalbreath added this pull request to the merge queue Jun 10, 2024
Merged via the queue into Kitware:master with commit 8c0a298 Jun 10, 2024
6 checks passed
@williamjallen williamjallen deleted the ctest-assert-ok branch June 11, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants