Remove legacy configuration system #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
requested changes
May 30, 2024
There are no references to "noregister" in the codebase
williamjallen
force-pushed
the
legacy-config-removal
branch
from
d62e6c8 to
3b9e7ae
Compare
josephsnyder
approved these changes
May 31, 2024
|
I'd like @zackgalbreath to take a brief look at this before we merge it |
zackgalbreath
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last traces of our legacy configuration system. While somewhat substantial in size, I made an attempt to break this into incremental commits, which may be easier to review.