-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Docker SSL handling #2227
Simplify Docker SSL handling #2227
Conversation
@zackgalbreath While the goal was to assist my Helm chart work, this is still very much a draft and I suspect that this may overlap with your work with the UBI image deployment. Feel free to push changes to this PR if you have any suggestions. |
046a53f
to
852dab0
Compare
The tests require the exposed port in the dev environment to match inside & outside the container, in addition to the issues observed by @zackgalbreath with the UBI image. As a result, I switched the port back to 8080. @zackgalbreath does this resolve the health check issue, or are the certificates the issue? |
The containers spin up successfully but the healthcheck issue remains. Reproducing this manually, the relevant error message is:
|
An alternative approach might be to simply ping both |
CDash currently requires SSL/TLS by default when using our production image. While useful for Docker Compose-based systems, this is a major pain point for k8s systems which handle TLS termination at ingress. See #2179, for example. This PR aims to ease these pains by conditionally enabling SSL/TLS if certificates are provided, in preparation for upcoming work to better support k8s-based deployments.
Fixes #2179.