Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic migration of legacy md5 passwords #2197

Merged
merged 1 commit into from
May 8, 2024
Merged

Remove automatic migration of legacy md5 passwords #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/Providers/AuthServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
use CDash\Model\Image;
use CDash\Model\Project;
use Illuminate\Auth\Access\Response;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Gate;
use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;
Expand All @@ -32,10 +31,6 @@ class AuthServiceProvider extends ServiceProvider
public function boot(): void
{
$this->registerPolicies();
Auth::provider('cdash', function ($app, array $config) {
return new CDashDatabaseUserProvider($app['hash'], $config['model']);
});

$this->defineGates();
}

Expand Down
43 changes: 0 additions & 43 deletions app/Providers/CDashDatabaseUserProvider.php
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions app/cdash/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,11 +533,8 @@ set_tests_properties(commitauthornotification PROPERTIES DEPENDS putdynamicbuild
add_php_test(subscribeprojectshowlabels)
set_tests_properties(subscribeprojectshowlabels PROPERTIES DEPENDS commitauthornotification)

add_php_test(rehashpassword)
set_tests_properties(rehashpassword PROPERTIES DEPENDS subscribeprojectshowlabels)

add_php_test(consistenttestingday)
set_tests_properties(consistenttestingday PROPERTIES DEPENDS rehashpassword)
set_tests_properties(consistenttestingday PROPERTIES DEPENDS subscribeprojectshowlabels)

add_php_test(numericupdate)
set_tests_properties(numericupdate PROPERTIES DEPENDS consistenttestingday)
Expand Down
29 changes: 0 additions & 29 deletions app/cdash/tests/test_rehashpassword.php
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions config/auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

'api' => [
'driver' => 'session',
'provider' => 'users',
'provider' => env('CDASH_AUTHENTICATION_PROVIDER', 'users'),
],
],

Expand All @@ -66,13 +66,13 @@
| sources which represent each model / table. These sources may then
| be assigned to any extra authentication guards you have defined.
|
| Supported: "database", "cdash"
| Supported: "database", "eloquent"
|
*/

'providers' => [
'users' => [
'driver' => 'cdash',
'driver' => 'eloquent',
'model' => App\Models\User::class,
],

Expand Down
40 changes: 0 additions & 40 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3077,26 +3077,6 @@ parameters:
count: 1
path: app/Providers/AuthServiceProvider.php

-
message: "#^Access to an undefined property Illuminate\\\\Contracts\\\\Auth\\\\Authenticatable\\:\\:\\$password\\.$#"
count: 1
path: app/Providers/CDashDatabaseUserProvider.php

-
message: "#^Dynamic call to static method Illuminate\\\\Database\\\\Eloquent\\\\Model\\:\\:save\\(\\)\\.$#"
count: 1
path: app/Providers/CDashDatabaseUserProvider.php

-
message: "#^Loose comparison via \"\\=\\=\" is not allowed\\.$#"
count: 1
path: app/Providers/CDashDatabaseUserProvider.php

-
message: "#^Method App\\\\Providers\\\\CDashDatabaseUserProvider\\:\\:validateCredentials\\(\\) has parameter \\$credentials with no value type specified in iterable type array\\.$#"
count: 1
path: app/Providers/CDashDatabaseUserProvider.php

-
message: "#^PHPDoc type array of property App\\\\Providers\\\\EventServiceProvider\\:\\:\\$listen is not the same as PHPDoc type array\\<string, array\\<int, string\\>\\> of overridden property Illuminate\\\\Foundation\\\\Support\\\\Providers\\\\EventServiceProvider\\:\\:\\$listen\\.$#"
count: 1
Expand Down Expand Up @@ -23971,26 +23951,6 @@ parameters:
count: 1
path: app/cdash/tests/test_registeruser.php

-
message: "#^Cannot access property \\$password on App\\\\Models\\\\User\\|null\\.$#"
count: 3
path: app/cdash/tests/test_rehashpassword.php

-
message: "#^Cannot call method save\\(\\) on App\\\\Models\\\\User\\|null\\.$#"
count: 1
path: app/cdash/tests/test_rehashpassword.php

-
message: "#^Loose comparison via \"\\!\\=\" is not allowed\\.$#"
count: 1
path: app/cdash/tests/test_rehashpassword.php

-
message: "#^Method RehashPasswordTestCase\\:\\:testSubscribeProjectShowsLabels\\(\\) has no return type specified\\.$#"
count: 1
path: app/cdash/tests/test_rehashpassword.php

-
message: """
#^Call to deprecated function pdo_fetch_array\\(\\)\\:
Expand Down