-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose build errors and warnings via GraphQL #2182
Expose build errors and warnings via GraphQL #2182
Conversation
4ed1100
to
9e6ea5d
Compare
Paused until #2183 is merged. |
9e6ea5d
to
e42ecfa
Compare
e42ecfa
to
aa9056e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, it looks like there are some issues that need to be resolved before this can be merged. The |
Needs further work. Current functionality works as intended, but intended purpose was not the best long-term design decision.
@josephsnyder I think this is ready for a re-review. The issue you observed is the result of my confusion about the fact that CDash stores two different types of warnings or errors. Adding the other type of warnings/errors to the API will be a significant undertaking, so I think it should be done in another PR (or several). This PR specifically adds the "basic" errors and warnings stored in the To reduce confusion about the fact that "build errors" can actually be warnings, I have created the term "build alert" to refer to the collection of both errors and warnings, with "build errors" and "build warnings" being more specific types of build alerts. Furthermore, I have created the terms "basic" and "rich" alerts to refer to the contents of the It would be good for @zackgalbreath to review this as well, particularly the documentation and terminology changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the BasicBuildAlert
doc type and it does nicely translate to a query where you can ask for a build for it's basicWarnings
and BasicErrors
with the context, line, and all the other expected fields. It LGTM but I'll hold off on adding it to the merge queue to give Zack a chance to chime in
This PR continues our ongoing effort to expose most of the database schema via GraphQL.