Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiteInformation type to GraphQL API #2181

Merged

Conversation

williamjallen
Copy link
Collaborator

The current network of site-related CDash pages is filled with inconsistencies, and at times, incorrect behavior, and is in dire need of a refactor. I plan to use an overhaul of these site pages as a testing ground for the new GraphQL API in the near future. To support that upcoming work, this PR exposes SiteInformation data via the GraphQL API and cleans up a bunch of related logic.

@williamjallen williamjallen force-pushed the siteinformation-refactor branch from acc9a28 to e0aed33 Compare April 29, 2024 18:05
@williamjallen williamjallen added this to the v3.5 milestone Apr 29, 2024
@williamjallen williamjallen marked this pull request as draft April 30, 2024 19:21
@williamjallen
Copy link
Collaborator Author

Paused until #2183 is merged.

@williamjallen williamjallen force-pushed the siteinformation-refactor branch from e0aed33 to 1192df1 Compare May 2, 2024 13:40
@williamjallen williamjallen marked this pull request as ready for review May 2, 2024 13:40
@williamjallen williamjallen requested a review from josephsnyder May 2, 2024 13:40
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to see the processor information for the test data submissions.

@williamjallen williamjallen added this pull request to the merge queue May 3, 2024
Merged via the queue into Kitware:master with commit 12ca03f May 3, 2024
6 checks passed
@williamjallen williamjallen deleted the siteinformation-refactor branch May 3, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants